ci, go.mod: bump to go 1.23 #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, need to bump golangci-lint too. |
mmorel-35
reviewed
Sep 17, 2024
mmorel-35
reviewed
Sep 17, 2024
|
@mmorel-35 oops, looks like we stepped on each other's toes. |
Now that go.mod matches our go version, we can stop setting go version in CI separately. Signed-off-by: Casey Callendrello <[email protected]>
Bumping golangci-lint to v1.61 introduced some new reasonable checks; fix the errors they found. Signed-off-by: Casey Callendrello <[email protected]>
Also, fix some deprecated config directives. Signed-off-by: Casey Callendrello <[email protected]>
|
whew. @mmorel-35 that should have it :-). |
mmorel-35
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop dependabot from adding a
toolchaindirective.