-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handle leak #2238
Fix handle leak #2238
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Bbulatov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
- doesn’t fix the issue at all, AFAICS
- Introduces a different leak
This is what defer
, and maybe the existing if !succeeded
pattern, is for.
Reference #2237 . |
Signed-off-by: Марк Булатов <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/containers/storage/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at PRs with unclear copyright status.
Signed-off-by: Марк Булатов <[email protected]>
Possible solve