Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused components #140

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove unused components #140

wants to merge 2 commits into from

Conversation

mluo24
Copy link
Collaborator

@mluo24 mluo24 commented Jan 1, 2023

Summary

There are a lot of unused pieces in the frontend that are no longer being used. To reduce the working size of the project as well as make the codebase more neat and straightforward, the components that have been unused and will be unused, either due to deprecation or impracticality, were deleted.

The following were removed:

  • All of CreateZing (afaik this concept has been removed for a while)
  • Input fields (this was solely used in CreateZing)
  • Button (and derivatives/styles)
  • Checkbox

Test Plan

JetBrains IDEs have a useful "check for references" feature which I used before I deleted something. Also, running the app and having everything working is a good sign that those components are just unused.

Notes

In a future pull request, there will be slight refactoring of the codebase so that components are in the right location and minimal styled components are used (as opposed to excessively).

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 5.

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Visit the preview URL for this PR (updated for commit 05c8e2e):

https://zing-lsc--pr140-component-cleanup-uet77dcw.web.app

(expires Sun, 08 Jan 2023 20:39:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1fc18307b178c916e2663810a6932f60b173c01b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants