Add admin #176
Merged
Add admin #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 158. |
|
Visit the preview URL for this PR (updated for commit ea57c36): https://zing-lsc--pr176-add-admin-xpi182yo.web.app (expires Sun, 13 Aug 2023 00:59:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1fc18307b178c916e2663810a6932f60b173c01b |
b3njamint
reviewed
May 4, 2023
There was a problem hiding this comment.
Very nice fix! I tried playing around with it and didn't find anything bad. I really like how you had the undo button in the "confirmation state," but it's really big and stretches the table row (idk if that is intentional).
Is the edit feature going to be done in a future PR?
mluo24
approved these changes
May 24, 2023
# Conflicts: # frontend/src/modules/Settings/Components/AdministratorsTable.tsx # frontend/src/modules/Settings/Components/Settings.tsx # frontend/src/modules/Settings/Components/types.ts
|
fixed it up and merged main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first step in making the full functionality to add admins to the allowed users list
Test Plan
The simple act of being able to add an admin is there
In this example, I was originally deleted
And then I filled myself out as a new administrator
After adding myself, I appear back on the administrators' table
Notes
Edit function still does not work but that can be overrided by removing an admin and then adding the same admin with updated information
Breaking Changes