Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for wi24 #185

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Bug fixes for wi24 #185

merged 3 commits into from
Jan 10, 2024

Conversation

JustKong13
Copy link
Contributor

@JustKong13 JustKong13 commented Jan 3, 2024

Summary

This pull request fixes a few bugs and prepares LSC for the winter semester, as well as

  • Dashboard no longer preloads spring 23
  • Fixed Email Regex to have to end with cornell.edu
  • Added winter '24 semester to metrics

Test Plan

Metrics page also has winter '24 as a valid option
Screenshot 2024-01-03 at 5 16 22 PM

Now correctly identifies invalid emails
Screenshot 2024-01-03 at 5 15 37 PM

Notes

In the future we will need to make the metrics semesters update automatically.

Breaking Changes

yarn.lock was updated when I did yarn install, it seems to me that the changes primarily consists of a new syntax update which just removed quotation marks.
package-lock.json was also updated when I did npm install, due to me working off of a new machine. There were no deletions or additions, just standard upgrades.

@JustKong13 JustKong13 requested a review from a team as a code owner January 3, 2024 22:45
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Justin Kong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 7.

Copy link

github-actions bot commented Jan 3, 2024

Visit the preview URL for this PR (updated for commit fc9bc36):

https://zing-lsc--pr185-bug-fixes-for-wi24-hei1p4s7.web.app

(expires Tue, 16 Jan 2024 17:44:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1fc18307b178c916e2663810a6932f60b173c01b

@@ -112,7 +112,7 @@ export const addStudentSurveyResponse = async (
}

// 0. Check if email is valid cornell.edu email.
const emailRegex = /^\[email protected]$/
const emailRegex = /^\w+@cornell\.edu$/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idr how regex works oop, does this like, make sure emails end with explicitly .edu and not like .education?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably has to do with the dot matching any character other than line terminators lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. btw, hi Changyuan!

Copy link
Contributor

@rgu0114 rgu0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention what dependency changes u made in package.lock/yarn.lock

@JustKong13 JustKong13 closed this Jan 9, 2024
@JustKong13 JustKong13 reopened this Jan 9, 2024
@JustKong13
Copy link
Contributor Author

Maybe mention what dependency changes u made in package.lock/yarn.lock

Just added that to the pull request! Basically I think for frontend there was an update which removed quotation marks around certain parts of the file (with no meaningful dependency changes), and for the backend our packages had version upgrades. There was no addition or deletion of any packages

Copy link
Contributor

@rgu0114 rgu0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@JustKong13 JustKong13 merged commit b773c27 into main Jan 10, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants