-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loadable slider #139
base: main
Are you sure you want to change the base?
Loadable slider #139
Conversation
update fork with cortinico/slidetoact
First of all, thank you very much for your contribution 🙏 Also for providing screenshots and documentation, really appreciated. I gave a first look at the code and it looks good. There are however a couple of discussion points we should solve:
|
Thanks for taking a look at my PR! Will look into separating out the |
Nothing specifically at the moment. Eventually a solution that relies on |
Description
When performing an action using this widget, I think it would be useful to convey a
loading
state before the slider iscomplete
orreset
. This PR attempts to allow consuming apps to perform some work i.e. call an API, set the slider into aloading
state and then once the work is complete, have the slider continue its complete animation.Loading slider example
Event logs with loading callback
Related PRs/Issues
#116
Todos
Please treat this PR as a prompt to a discussion rather than a mergeable PR as I'd imagine we'd want the
loading
icon to act like a spinner or perhaps allow the animation to be defined in an attribute on the slider?Look forward to a review when you get the chance.