HTTP API for CosmoScout

[Schneegans]

I will add some documentation, but you can already start to play around! Simply checkout the branch, compile the externals and CosmoScout, launch it, and navigate to http://localhost:9001.

See cosmoscout/csp-web-api#1.

Edit: The plugin is not loaded per default now. You have to add this to you settings:

"csp-web-api": {
  "port": 9001,
  "page": "../share/resources/gui/example-web-frontend.html"
},

[github-actions]

Pull Request Test Coverage Report for Build 89782358

• 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.03%) to 4.191%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/cs-utils/SafeQueue.hpp	0	8	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/cs-utils/utils.hpp	4	55.56%

Totals
Change from base Build 89235985:	-0.03%
Covered Lines:	570
Relevant Lines:	13600

---

💛 - Coveralls

[JonasGilg]

On Windows I was promptet for admin privileges after (or at the end) of plugin loading. I denied the request and the applications seems to work normally.

I can't reproduce it, since Windows seems to remember the decision. (I will try and work around that).

[JonasGilg]

Is this right?

[JonasGilg]

This plugin introduces a new external dependency that has to be installed for the whole of CosmoScout for a feature that is really specialized and only used within this plugin.

Do you think we can add dependencies of plugins that are only required by that plugin differently?
The first thing coming to my mind is using CMake's exernal projects feature: https://cmake.org/cmake/help/latest/module/ExternalProject.html

[Schneegans]

This is a difficult question. With dependencies such as civetweb which can be build easily and do not drag in other things, I am quite happy to treat it like it's done now. This is especially true once we put the core plugins into the main repository. And it can happen that we use the library in other plugins in the future - curl, curlpp and cares were only required by the csp-lod-bodies plugin when we introduced it and now they are required by multiple plugins and cs-utils.

However there are more complicated dependencies (like VTK in the scivis branch). The best solution would be along these lines:

• Get rid of make_externals.sh and make_externals.bat
• In the main CMakeLists.txt we would call ExternalProject_Add for each core dependency.
• Each plugin would call ExternalProject_Add for all additional dependencies. This however can lead to multiple calls to ExternalProject_Add for the same dependency. This would need to be resolved, especially if multiple plugins request different versions of the same dependency.
• It also has to work for external dependencies which do not use CMake

What do you think? Would this be possible? But it's definitely not in the scope of this pull request...

[JonasGilg]

Moved this discussion to an issue: #150

[Schneegans]

I think I will remove the plugin from the default config, as it's not required for standard use cases. Are there any other ideas?