-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use the accountId to make Google Drive URLSessions unique #32
Actually use the accountId to make Google Drive URLSessions unique #32
Conversation
WalkthroughThe update focuses on refining the Google Drive integration for a cloud storage application. Specifically, it addresses the issue of constructing a unique identifier for background sessions by incorporating the account ID, ensuring a more reliable and personalized connection for each user's data transactions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1 hunks)
Additional comments: 1
Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1)
- 61-62: The fix to include the account ID in the session identifier string is a crucial step towards resolving the issue with background URLSession identifiers. However, there are a couple of points to consider:
- Error handling for
getAccountID()
: Ensure that potential errors fromgetAccountID()
are handled gracefully. It's important to consider what should happen if the account ID cannot be retrieved due to an error.- Typo in the session identifier: The identifier string
"Crytomator-GoogleDriveSession-\(accountId)-\(bundleId)"
contains a typo (Crytomator
should beCryptomator
). This typo should be corrected to maintain consistency and avoid confusion.- "Crytomator-GoogleDriveSession-\(accountId)-\(bundleId)" + "Cryptomator-GoogleDriveSession-\(accountId)-\(bundleId)"Consider adding error handling for the
getAccountID()
call to ensure the app behaves as expected in case of an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my, good catch with that typo! Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- Sources/CryptomatorCloudAccess/GoogleDrive/GoogleDriveCloudProvider.swift
In cryptomator/ios#342 it has been reported that it's not possible to actually use multiple vaults in parallel with multiple Google Drive accounts.
This is basically because of a typo which resulted in the same background URLSession identifier for all Google Drive accounts. Since running background URLSessions need to be uniquely identified by their identifier all the additionally created ones (for the 2nd Google Drive account, etc.) were broken which resulted in the linked issue.
Summary by CodeRabbit