use pagination where required #15
Conversation
| } | ||
|
|
||
| # single page result-s (no pagination), have no Link: section, the grep result is empty | ||
| last_page=`curl -I --tlsv1.2 -s "https://api.github.com/repos/gruntwork-io/terragrunt/tags?per_page=100" -H "${GITHUB_API_HEADER_ACCEPT}" | grep '^link:' | sed -e 's/^link:.*page=//g' -e 's/>.*$//g'` |
There was a problem hiding this comment.
Just a heads up, I was testing this fix and found that the pagination did not work unless link was capitalized.
this is no longer the case, lowercase is working again
|
This would fix #16 |
|
@michaelpporter any chance for a new release? |
|
@tsunamishaun I have no control over this repo. |
|
Tested this on my tgenv as I was hitting the same issue when trying to install an old version (0.18.7). This fix works perfectly, excellent work by @NixM0nk3y - @cunymatthieu please can we get this merged into master? |
|
@cunymatthieu can we get this merged? would be important to be able to install older versions |
|
Yes. This would have also helped us today to have this merged in |
|
@fabiogermann @ChrisLanks this project has been abandoned for years. A few of us forked the project and fixed this issue in tgenv/tgenv#2 |
Githubs API now only returns 100 items from its API ( even when asking for 1000)
The number of terragrunt release now greatly exceeds the 100 (245/ 3 pages) which means older 0.17 era versions are no longer found by tgenv.
This commit intros pagination to allow all versions to be found