-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSR-2120] fix: passes, failed, skipped tests counting #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelangaranocurrents this looks good except for one thing regarding the status
That one thing is that in all the frameworks we current support, skipped should be reported as pending
to Currents.
I believe the jest reporter is already doing this for the testcase level, we need to do the same for the convert command.
Skipped in currents is for tests that were supposed to run, but didn't. (Sortof a cypress legacy item I think). We count these towards failures in Currents.
Got you, thanks for noticing that @twk3 I just changed it to be pending when there are skipped tests, it worked properly in the dashboard: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miguelangaranocurrents
This looks to be working as expected
Description
This PR fixes the count of skipped tests as well as the failed and passed tests, taking into account the skipped as well.
PR Checklist
Release Plan
I have added
release:<service>
labels to this PRWhat is the release order of the affected services? N/A
What infrastructure changes are requires? N/A
Demo
https://www.loom.com/share/ba8d99a52f704719b38eaa9f8f000fdc?sid=a46ad995-8c9c-4e1a-b18b-6731e6e60a75
Manual Testing
To reproduce:
To test the fix:
Use this as example XML file: