Merge pull request #10 from customgento/DEV-362-add-github-actions

Add github actions, DEV-362
customgento · Jun 5, 2024 · ef2f0e1 · ef2f0e1
2 parents 546c83e + c075dad
commit ef2f0e1
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 7 deletions.
diff --git a/.github/workflows/coding-standard.yml b/.github/workflows/coding-standard.yml
@@ -0,0 +1,6 @@
+name: ExtDN M2 Coding Standard
+on: [push, pull_request]
+
+jobs:
+  phpcs:
+    uses: customgento/m2-github-actions/.github/workflows/coding-standard.yml@main
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
@@ -0,0 +1,9 @@
+name: ExtDN M2 Integration
+on: [push, pull_request]
+
+jobs:
+  integration:
+    uses: customgento/m2-github-actions/.github/workflows/integration.yml@main
+    with:
+      module_name: CustomGento_DefaultStoreCodeRemover
+      composer_name: customgento/module-default-store-code-remover-m2
diff --git a/.github/workflows/mess-detector.yml b/.github/workflows/mess-detector.yml
@@ -0,0 +1,6 @@
+name: ExtDN M2 Mess Detector
+on: [push, pull_request]
+
+jobs:
+  phpmd:
+    uses: customgento/m2-github-actions/.github/workflows/mess-detector.yml@main
diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
@@ -0,0 +1,8 @@
+name: ExtDN M2 PHPStan
+on: [push, pull_request]
+
+jobs:
+  phpstan:
+    uses: customgento/m2-github-actions/.github/workflows/phpstan.yml@main
+    with:
+      composer_name: customgento/module-default-store-code-remover-m2
diff --git a/Helper/StoreUrl.php b/Helper/StoreUrl.php
@@ -6,8 +6,11 @@
 
 use Magento\Store\Api\Data\StoreInterface;
 use Magento\Store\Model\Store;
+/** @phpstan-ignore-next-line */
 use MageWorx\SeoBase\Helper\StoreUrl as MageworxStoreUrl;
 
+// phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses
+
 if (class_exists(MageworxStoreUrl::class)) {
     class StoreUrl extends MageworxStoreUrl
     {

diff --git a/Test/Integration/CheckDefaultStoreCodeHiddenInUrlTest.php b/Test/Integration/CheckDefaultStoreCodeHiddenInUrlTest.php
@@ -38,7 +38,7 @@ public function testStoreCodeIsShownInNonDefaultStoreUrl(): void
     {
         $store = $this->storeRepository->get('test');
         $this->config->setValue(Store::XML_PATH_STORE_IN_URL, true, ScopeInterface::SCOPE_STORE, $store->getCode());
-        $this->assertContains('test', $store->getBaseUrl());
+        $this->assertStringContainsString('test', $store->getBaseUrl());
     }
 
     /**
@@ -47,21 +47,31 @@ public function testStoreCodeIsShownInNonDefaultStoreUrl(): void
     public function testStoreCodeIsNotShownInNonDefaultStoreUrl(): void
     {
         $store = $this->storeRepository->get('test');
-        $this->config->setValue(Store::XML_PATH_STORE_IN_URL, false, ScopeInterface::SCOPE_STORE, $store->getCode());
-        $this->assertNotContains('test', $store->getBaseUrl());
+        $this->config->setValue(
+            Store::XML_PATH_STORE_IN_URL,
+            false,
+            ScopeInterface::SCOPE_STORE,
+            $store->getCode()
+        );
+        $this->assertStringNotContainsString('test', $store->getBaseUrl());
     }
 
     public function testStoreCodeIsNotShownInDefaultStoreUrl(): void
     {
         $store = $this->storeRepository->get('default');
-        $this->config->setValue(Store::XML_PATH_STORE_IN_URL, false, ScopeInterface::SCOPE_STORE, $store->getCode());
-        $this->assertNotContains('default', $store->getBaseUrl());
+        $this->config->setValue(
+            Store::XML_PATH_STORE_IN_URL,
+            false,
+            ScopeInterface::SCOPE_STORE,
+            $store->getCode()
+        );
+        $this->assertStringNotContainsString('default', $store->getBaseUrl());
     }
 
     public function testStoreCodeIsShownInDefaultStoreUrl(): void
     {
         $store = $this->storeRepository->get('default');
         $this->config->setValue(Store::XML_PATH_STORE_IN_URL, true, ScopeInterface::SCOPE_STORE, $store->getCode());
-        $this->assertNotContains('default', $store->getBaseUrl());
+        $this->assertStringNotContainsString('default', $store->getBaseUrl());
     }
-}
+}