Issue #6 : Add Namespace and Probes Configuration to Kubernetes Manifests #7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,109 +1,201 @@ | ||
| { | ||
| "title": "Values", | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "description": "Application name", | ||
| "type": "string" | ||
| }, | ||
| "namespace": { | ||
| "description": "Kubernetes namespace", | ||
| "type": "string" | ||
| }, | ||
| "general": { | ||
| "description": "General configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "image": { | ||
| "description": "Container image", | ||
| "type": "string" | ||
| }, | ||
| "version": { | ||
| "description": "Container image version", | ||
| "type": "string" | ||
| }, | ||
| "environment": { | ||
| "description": "Environment variables", | ||
| "type": "object", | ||
| "additionalProperties": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "required": [ | ||
| "image", | ||
| "version" | ||
| ] | ||
| }, | ||
| "scaling": { | ||
| "description": "Scaling configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "replicas": { | ||
| "description": "Number of replicas", | ||
| "type": "integer" | ||
| }, | ||
| "resources": { | ||
| "description": "Resource limits and requests", | ||
| "type": "object", | ||
| "properties": { | ||
| "cpu": { | ||
| "description": "CPU resource request", | ||
| "type": "string" | ||
| }, | ||
| "memory": { | ||
| "description": "Memory resource limit", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| }, | ||
| "required": [ | ||
| "replicas" | ||
| ] | ||
| }, | ||
| "probes": { | ||
| "description": "Probe configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "enabled": { | ||
| "description": "Enable probes", | ||
| "type": "boolean" | ||
| }, | ||
| "startup": { | ||
RohanRusta21 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "description": "Startup probe configuration", | ||
| "type": "object", | ||
| "properties": { | ||
RohanRusta21 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "path": { | ||
| "description": "HTTP path for probe", | ||
| "type": "string" | ||
| }, | ||
| "initialDelaySeconds": { | ||
| "description": "Initial delay for probe", | ||
| "type": "integer" | ||
| }, | ||
| "periodSeconds": { | ||
| "description": "Period for probe", | ||
| "type": "integer" | ||
| }, | ||
| "failureThreshold": { | ||
| "description": "Failure threshold for probe", | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "path", | ||
| "initialDelaySeconds", | ||
| "periodSeconds", | ||
| "failureThreshold" | ||
| ] | ||
| }, | ||
| "liveness": { | ||
| "description": "Liveness probe configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "path": { | ||
| "description": "HTTP path for probe", | ||
| "type": "string" | ||
| }, | ||
| "initialDelaySeconds": { | ||
| "description": "Initial delay for probe", | ||
| "type": "integer" | ||
| }, | ||
| "periodSeconds": { | ||
| "description": "Period for probe", | ||
| "type": "integer" | ||
| }, | ||
| "failureThreshold": { | ||
| "description": "Failure threshold for probe", | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "path", | ||
| "initialDelaySeconds", | ||
| "periodSeconds", | ||
| "failureThreshold" | ||
| ] | ||
| }, | ||
| "readiness": { | ||
|
There was a problem hiding this comment. Can you add There was a problem hiding this comment. Hey @petar-cvit , Yup its done now. Please Review it :) |
||
| "description": "Readiness probe configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "path": { | ||
| "description": "HTTP path for probe", | ||
| "type": "string" | ||
| }, | ||
| "initialDelaySeconds": { | ||
| "description": "Initial delay for probe", | ||
| "type": "integer" | ||
| }, | ||
| "periodSeconds": { | ||
| "description": "Period for probe", | ||
| "type": "integer" | ||
| }, | ||
| "failureThreshold": { | ||
| "description": "Failure threshold for probe", | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "path", | ||
| "initialDelaySeconds", | ||
| "periodSeconds", | ||
| "failureThreshold" | ||
| ] | ||
| } | ||
| }, | ||
| "required": [ | ||
| "enabled", | ||
|
There was a problem hiding this comment. can we add There was a problem hiding this comment. Hi @petar-cvit , actually initially I tried to have separate toggle for each probe. But it was not working fine. Maybe will try it again. There was a problem hiding this comment. Please do. You can paste the error here if you want and we can try to figure it out There was a problem hiding this comment. Can you explain me this error. UI changes performed : There was a problem hiding this comment. We refactored manifest rendering so you can try out the template again with the updated version. |
||
| "startup", | ||
| "liveness", | ||
| "readiness" | ||
| ] | ||
| }, | ||
| "networking": { | ||
| "description": "Networking configuration", | ||
| "type": "object", | ||
| "properties": { | ||
| "expose": { | ||
| "description": "Expose container port", | ||
| "type": "boolean" | ||
| }, | ||
| "port": { | ||
| "description": "Container port", | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "expose", | ||
| "port" | ||
| ] | ||
| } | ||
| }, | ||
| "order": [ | ||
| "name", | ||
| "namespace", | ||
| "general", | ||
| "scaling", | ||
| "probes", | ||
| "networking" | ||
| ], | ||
| "required": [ | ||
| "name", | ||
| "namespace", | ||
| "general", | ||
| "scaling", | ||
| "probes", | ||
| "networking" | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,32 @@ | ||
| name: my-app | ||
| namespace: default | ||
| general: | ||
| image: nginx | ||
| version: 1.14.2 | ||
| environment: | ||
| ENVIRONMENT: production | ||
| scaling: | ||
| replicas: 3 | ||
| resources: | ||
| cpu: 1 | ||
| memory: 512 | ||
| probes: | ||
| enabled: true | ||
| startup: | ||
| path: "/" | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 10 | ||
| failureThreshold: 3 | ||
| liveness: | ||
| path: "/" | ||
| initialDelaySeconds: 10 | ||
| periodSeconds: 20 | ||
| failureThreshold: 3 | ||
| readiness: | ||
| path: "/" | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 10 | ||
| failureThreshold: 3 | ||
| networking: | ||
| expose: true | ||
| port: 8080 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave this default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we can