-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom prompts #4037
feat: custom prompts #4037
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Co-authored-by: Chris Bongers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giant work! 💪
packages/shared/src/components/feeds/FeedSettings/components/SmartPrompts.tsx
Outdated
Show resolved
Hide resolved
@@ -32,7 +31,7 @@ export interface UseChat { | |||
queryKey: QueryKey; | |||
data: Search; | |||
isLoading: boolean; | |||
handleSubmit(event: MouseEvent, value: string): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave the event
as second optional param, if we are refactoring, because we could need it in the future
packages/shared/src/components/post/smartPrompts/SmartPromptResponse.tsx
Show resolved
Hide resolved
Co-authored-by: Ante Barić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing and noted it in the slack channel. Only thing I would like to fix is validation of prompt
flags on API.
Aside from that UI seems to work good 👌 Approving code wise.
…rompts # Conflicts: # packages/shared/src/lib/image.ts
Changes
Introduces smart prompts to posts.
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-custom-prompts.preview.app.daily.dev