Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom prompts #4037

Merged
merged 37 commits into from
Feb 5, 2025
Merged

feat: custom prompts #4037

merged 37 commits into from
Feb 5, 2025

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Jan 3, 2025

Changes

Introduces smart prompts to posts.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://feat-custom-prompts.preview.app.daily.dev

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Feb 5, 2025 2:33pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Feb 5, 2025 2:33pm

@rebelchris rebelchris changed the title Feat custom prompts feat: custom prompts Jan 3, 2025
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giant work! 💪

@@ -32,7 +31,7 @@ export interface UseChat {
queryKey: QueryKey;
data: Search;
isLoading: boolean;
handleSubmit(event: MouseEvent, value: string): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave the event as second optional param, if we are refactoring, because we could need it in the future

packages/shared/src/lib/query.ts Outdated Show resolved Hide resolved
packages/shared/src/graphql/search.ts Show resolved Hide resolved
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and noted it in the slack channel. Only thing I would like to fix is validation of prompt flags on API.

Aside from that UI seems to work good 👌 Approving code wise.

@rebelchris rebelchris merged commit e75016e into main Feb 5, 2025
9 of 10 checks passed
@rebelchris rebelchris deleted the feat-custom-prompts branch February 5, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants