feat: social share experiment #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
ilasw,
capJavert,
sshanzel and
nensidosari
rebelchris
approved these changes
Feb 6, 2025
Comment on lines
69
to
73
| useEffect(() => { | ||
| if (linkData) { | ||
| setHasCopied(true); | ||
| } | ||
| }, [linkData]); |
There was a problem hiding this comment.
I don't think you need a useEffect here right?
Could just evaluate !!linkData?
| const { logEvent } = useLogContext(); | ||
| return ( | ||
| <Button | ||
| variant={ButtonVariant.Float} |
There was a problem hiding this comment.
Maybe check with Tsahi on this transparency, personally find it very hard to see.
|
After discussion with Tsahi we updated the icons on the cover to be white instead. Looks alright, except for the Reddit alien looks a bit creepy 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Introduces a new experiment to share on social when copying link
Examples:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
yes,
social_shareManual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-777.preview.app.daily.dev