Implement "atpath" asset endpoint #2193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures AssetPath path ordering is consistent with that of `Asset.path`.
This allows for the debug toolbar to be made use of from the swagger page
I'm not really a fan of this path, not least because I don't anticipate many |
jwodder
reviewed
Feb 24, 2025
jjnesbitt
force-pushed
the
asset-atpath-drf
branch
from
88e1fa5 to
72d6084
Compare
|
I see there is a single test failure, which seems unrelated, but I'll investigate. |
We discussed this internally and decided that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2172
This implements the design doc laid out in #2155 (link).
There are some additional changes included in this PR, that may seem unrelated, but were necessary for this feature's functionality. One such change is the slight restructuring of
urls.py, which was done in order to mount two separate swagger pages, with their own respective visible endpoints. This is actually an overall code quality enhancement, as before, our URL and swagger configuration was very ad hoc.@jwodder The only deviation from that design doc is that the endpoint is instead hosted at
api/webdav/assets/atpath, withdandiset_idandversion_idprovided as query arguments. This is done to separate concerns from the public API, and what's needed for webdav. Let us know if you find any issues.