-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "atpath" asset endpoint #2193
base: master
Are you sure you want to change the base?
Conversation
This ensures AssetPath path ordering is consistent with that of `Asset.path`.
This allows for the debug toolbar to be made use of from the swagger page
I'm not really a fan of this path, not least because I don't anticipate many |
88e1fa5
to
72d6084
Compare
I see there is a single test failure, which seems unrelated, but I'll investigate. |
We discussed this internally and decided that the |
Closes #2172
This implements the design doc laid out in #2155 (link).
There are some additional changes included in this PR, that may seem unrelated, but were necessary for this feature's functionality. One such change is the slight restructuring of
urls.py
, which was done in order to mount two separate swagger pages, with their own respective visible endpoints. This is actually an overall code quality enhancement, as before, our URL and swagger configuration was very ad hoc.@jwodder The only deviation from that design doc is that the endpoint is instead hosted at
api/webdav/assets/atpath
, withdandiset_id
andversion_id
provided as query arguments. This is done to separate concerns from the public API, and what's needed for webdav. Let us know if you find any issues.