Merge pull request #1458 from 3w36zj6/issue-1374

fix: remove `GITHUB_URL` environment variable as a fallback for the GitHub API URL
danger · Aug 6, 2024 · b67d710 · b67d710
2 parents 92d2525 + 18016ae
commit b67d710
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/source/platforms/github/GitHubAPI.ts b/source/platforms/github/GitHubAPI.ts
@@ -52,7 +52,7 @@ export class GitHubAPI {
     // A token should have been set by this point
     const token = accessTokenForApp || this.token!
 
-    const host = process.env["DANGER_GITHUB_API_BASE_URL"] || process.env["GITHUB_URL"] || undefined
+    const host = process.env["DANGER_GITHUB_API_BASE_URL"] || "https://api.github.com"
     const options: ConstructorParameters<typeof GitHubNodeAPI>[0] & { debug: boolean } = {
       debug: !!process.env.LOG_FETCH_REQUESTS,
       baseUrl: host,
@@ -515,7 +515,7 @@ ${file.patch}
     }
 
     const containsBase = path.startsWith("http")
-    const baseUrl = process.env["DANGER_GITHUB_API_BASE_URL"] || process.env["GITHUB_URL"] || "https://api.github.com"
+    const baseUrl = process.env["DANGER_GITHUB_API_BASE_URL"] || "https://api.github.com"
     const url = containsBase ? path : `${baseUrl}/${path}`
 
     let customAccept = {}

diff --git a/source/platforms/github/customGitHubRequire.ts b/source/platforms/github/customGitHubRequire.ts
@@ -61,7 +61,7 @@ export async function getGitHubFileContents(
 ) {
   const refString = ref ? `?ref=${ref}` : ""
   const containsBase = path.startsWith("http")
-  const baseUrl = process.env["DANGER_GITHUB_API_BASE_URL"] || process.env["GITHUB_URL"] || "https://api.github.com"
+  const baseUrl = process.env["DANGER_GITHUB_API_BASE_URL"] || "https://api.github.com"
   const URLPath = `repos/${repoSlug}/contents/${path}${refString}`
   const url = containsBase ? URLPath : `${baseUrl}/${URLPath}`
 

diff --git a/source/runner/dslGenerator.ts b/source/runner/dslGenerator.ts
@@ -39,7 +39,7 @@ export const jsonDSLGenerator = async (
       github: {
         accessToken: process.env["DANGER_GITHUB_API_TOKEN"] || process.env["GITHUB_TOKEN"] || "NO_TOKEN",
         additionalHeaders: {},
-        baseURL: process.env["DANGER_GITHUB_API_BASE_URL"] || process.env["GITHUB_URL"] || undefined,
+        baseURL: process.env["DANGER_GITHUB_API_BASE_URL"] || "https://api.github.com",
       },
       cliArgs,
     },