Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update not PR condition for GH workflow #1453

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sayali10
Copy link
Contributor

@sayali10 sayali10 commented Jun 4, 2024

@sayali10 sayali10 mentioned this pull request Jun 4, 2024
Copy link
Member

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that event name. Necessary for fork-based PRs!

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

From: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@orta
Copy link
Member

orta commented Jun 5, 2024

Thanks!

@orta orta merged commit ef0d432 into danger:main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants