Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose commit stats #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

expose commit stats #1

wants to merge 4 commits into from

Conversation

danielnorberg
Copy link
Owner

@danielnorberg danielnorberg commented May 31, 2024

for review before submission to upstream yoshidan#272

@yoshidan
Copy link

yoshidan commented Jun 3, 2024

Thanks for the proposal.
Breaking change is acceptable, as it will add useful information and there is almost no delay due to the additional processing.
Could you please change the return value of the existing read_write_transaction and read_write_transaction_with_option from Option<Timestamp> to Option<CommitResult>.

@danielnorberg danielnorberg force-pushed the dano/tx-commit-response branch from cfa9ff3 to 902d7fe Compare January 31, 2025 19:56
@danielnorberg danielnorberg force-pushed the dano/tx-commit-response branch from 2fa62ca to 51d3ea9 Compare January 31, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants