-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparing lossless versus lossy compression for Windows users #307
Comparing lossless versus lossy compression for Windows users #307
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-307 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-19 06:44:12 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, @JeremyPike. I like your proposed solution except that we do not list PowerShell in the setup instructions for the lesson.
If it would be needed only for this one, optional exercise, I suggest to add a note to the beginning of the exercise, stating that Windows users will need PowerShell installed to complete that exercise and linking to installation instructions.
If it is required for any other exercises/examples in the lesson, PowerShell should instead be added to the setup instructions.
Thanks @tobyhodges, I'll leave this for now and come back to it once Ive gone through the rest of the course to see if Powershell would be useful elsewhere. I think modern versions of Windows (10 and newer) come shipped with some version of Powershell so in most cases no install would be required (but a link just in case wouldn't hurt). |
@tobyhodges so I only found one other terminal command in the course which I've added the Powershell equivalent command for. I've also added a note in the setup instructions but I would be surprised if anyone didn't have it installed by default. Note in JupterLab Windows users get Powershell if they open a terminal so that works nicely too :) |
62ffe04
to
5edf04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, @tobyhodges! I caught a few details which this PR only brought to my attention now.
review suggestions Co-authored-by: Marianne Corvellec <[email protected]>
Thanks, all suggestions made :) |
Auto-generated via {sandpaper} Source : 0c8bfff Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-19 13:24:53 +0000 Message : Merge pull request #307 from JeremyPike/comparing-compression-windows Comparing lossless versus lossy compression for Windows users
Auto-generated via {sandpaper} Source : 23ef1d9 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-12-19 13:25:49 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c8bfff Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-19 13:24:53 +0000 Message : Merge pull request #307 from JeremyPike/comparing-compression-windows Comparing lossless versus lossy compression for Windows users
The Comparing lossless versus lossy compression exercise does not work for Windows users who do not have a bash terminal with zip installed (I tried Git for Windows but zip not included). Here I've added a potential command line solution using Windows PowerShell.