-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keeping low intensity pixels #310
Keeping low intensity pixels #310
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-310 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-11 11:16:47 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @JeremyPike! I remember there were issues with this exercise and I guess its fixing was never completed... I like your changes and additions.
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Thank you @mkcor for the review and nice changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, @JeremyPike! Thanks again. In case you may not be aware of it, you can apply several suggestions at once, as a batch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes
Co-authored-by: Marianne Corvellec <[email protected]>
Auto-generated via {sandpaper} Source : b9bc009 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-13 09:44:57 +0000 Message : Merge pull request #310 from bear-rsg/keeping-low-intensity-pixels Keeping low intensity pixels
Auto-generated via {sandpaper} Source : b175e96 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-12-13 09:45:54 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : b9bc009 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-13 09:44:57 +0000 Message : Merge pull request #310 from bear-rsg/keeping-low-intensity-pixels Keeping low intensity pixels
I've made a few changes to this exercise to either make it easier for participants to follow or to correct some minor mistakes.
Instructions
cmap
,vmin
andvmax
arguments formatplotlib.pyplot.imshow
as these are needed andvmin
andvmax
havn't been introduced yet.Solution