Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional capstone exercise #317

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

JeremyPike
Copy link
Contributor

@JeremyPike JeremyPike commented Dec 13, 2023

Potential optional exercise adding the features suggested at the end of the challenge solution. I think its nice to include as a stretch exercise. If you like and want to include please double check I've got the formatting right as I havn't added an exercise yet :)

Copy link

github-actions bot commented Dec 13, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-317

The following changes were observed in the rendered markdown documents:

 09-challenges.md | 41 +++++++++++++++++++++++++++++++++++++++++
 md5sum.txt       |  2 +-
 2 files changed, 42 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-13 08:43:11 +0000

@JeremyPike JeremyPike changed the title optional capstone exercise Optional capstone exercise Dec 13, 2023
@JeremyPike JeremyPike marked this pull request as draft December 13, 2023 08:38
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
@JeremyPike JeremyPike marked this pull request as ready for review December 13, 2023 08:44
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this, @JeremyPike, and agree that a "stretch goal" challenge is a good thing to include. In general, I hope others will come along and suggest other kinds of capstone challenge as well (there used to be two in an older version of the lesson).

@tobyhodges tobyhodges merged commit 7065592 into datacarpentry:main Dec 15, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
Auto-generated via {sandpaper}
Source  : 7065592
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-15 14:35:17 +0000
Message : Merge pull request #317 from bear-rsg/capstone-suggestions

Optional capstone exercise
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
Auto-generated via {sandpaper}
Source  : 099d229
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-15 14:36:16 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7065592
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-15 14:35:17 +0000
Message : Merge pull request #317 from bear-rsg/capstone-suggestions

Optional capstone exercise
@JeremyPike JeremyPike deleted the capstone-suggestions branch February 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants