Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ndarray.size instead of multiplying #338

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

nanosec
Copy link
Contributor

@nanosec nanosec commented Jan 30, 2025

Use binary_mask.size instead of multiplying the elements of binary_mask.shape.

Copy link

github-actions bot commented Jan 30, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-338

The following changes were observed in the rendered markdown documents:

 07-thresholding.md | 13 +++----------
 LICENSE.md         |  6 +++---
 md5sum.txt         |  4 ++--
 3 files changed, 8 insertions(+), 15 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-02-05 16:53:09 +0000

github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@K-Meech
Copy link
Contributor

K-Meech commented Feb 5, 2025

Looks good to me - thanks @nanosec ! This is a nice simplification over using the width/height of the image.
I'll leave this open for a few more days, in case the other maintainers have comments - otherwise I'll merge it later this week 😄

@K-Meech K-Meech requested a review from a team February 5, 2025 17:27
@K-Meech K-Meech merged commit bfaf89e into datacarpentry:main Feb 9, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
Auto-generated via `{sandpaper}`
Source  : bfaf89e
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2025-02-09 16:51:23 +0000
Message : Merge pull request #338 from nanosec/size

Use ndarray.size instead of multiplying
github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
Auto-generated via `{sandpaper}`
Source  : f0b23cd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-09 16:52:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : bfaf89e
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2025-02-09 16:51:23 +0000
Message : Merge pull request #338 from nanosec/size

Use ndarray.size instead of multiplying
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Auto-generated via `{sandpaper}`
Source  : f0b23cd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-09 16:52:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : bfaf89e
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2025-02-09 16:51:23 +0000
Message : Merge pull request #338 from nanosec/size

Use ndarray.size instead of multiplying
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
Auto-generated via `{sandpaper}`
Source  : f0b23cd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-09 16:52:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : bfaf89e
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2025-02-09 16:51:23 +0000
Message : Merge pull request #338 from nanosec/size

Use ndarray.size instead of multiplying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants