Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8549 Adds downstream JDBC connector deployment instructions #6107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roldanbob
Copy link
Contributor

DBZ-8549 Adds downstream deployment instructions to the JDBC connector doc.

Tested in a local Antora build. These changes have no effect on the community version of the documentation.

This is ready for upstream review, but should not be merged yet, pending resolution of downstream build issues.

I would especially appreciate it if someone could review the CR examples. I modeled these examples after the source connector examples where I assumed that made sense, but I was unsure where to include certain entries, for example,
where do we define the topics array that lists the Kafka topics from which the connector consumes change events?

I placed this in the connector YAML examples (L753 and L994), e.g.,

spec:
  class: io.debezium.connector.jdbc.JdbcSinkConnector  // <2>
  tasksMax: 1  // <3>
  topics: // <4>
    - orders

Is that correct?

@roldanbob roldanbob requested a review from jpechane January 18, 2025 03:20
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roldanbob overall this LGTM, I just left one small nit-pick.

To deploy a {prodname} JDBC connector, you install the {prodname} JDBC connector archive, configure the connector, and start the connector by adding its configuration to Kafka Connect.

.Prerequisites
* link:https://zookeeper.apache.org/[Apache ZooKeeper], link:http://kafka.apache.org/[Apache Kafka], and link:{link-kafka-docs}.html#connect[Kafka Connect] are installed.
* A destination database is installed and configured to accept JDBC connections.
* Source and destination databases are installed and are configured to accept JDBC connections.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to reference a "Source" in this context, as the JDBC sink connector can be used with non-database sources.

@Naros
Copy link
Member

Naros commented Jan 18, 2025

As to your question, the topics shouldn't be an array as you implemented, but AFAICT its just a connector configuration that is a comma-separated list of values in the connector configuration section, just like you would provide this as part of the JSON, as shown here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants