Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bisonw-desktop/darwin: don't rebuild web assets for release branch builds #3075

Merged
merged 1 commit into from
Nov 12, 2024
Merged

bisonw-desktop/darwin: don't rebuild web assets for release branch builds #3075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions client/cmd/bisonw-desktop/pkg/pkg-darwin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,14 @@ function prepare() {
}

# Build the webpack bundle prior to building the webserver package, which embeds
# the files.
pushd ../../../webserver/site
go generate # just check, no write
npm ci
npm run build
popd
# the files. Don't do this for release builds because the assets are committed.
if [ "${META}" != "release" ]; then
pushd ../../../webserver/site
go generate # just check, no write
npm ci
npm run build
popd
fi

function build_targets() {
for TARGET in ${TARGETS}; do
Expand Down
Loading