fix: jumpToMessage not working sometimes
#4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-jumpToMessage-different-chat
branch
from
100bd20 to
64b4aad
Compare
WofWca
force-pushed
the
wofwca/fix-jumpToMessage-different-chat
branch
from
64b4aad to
7209c8f
Compare
...when the chatId of the message is different from the currently open chat. Closes #4508. This is probably related to the React upgrade (#3958), which changed the behaviour of `useEffect`. The issue was that we called `window.__internal_jump_to_message` _before_ `MessageListStore` has been reinstantiated after the change of chatId (in `useMessageList`), so we'd call it on an old instance. I think there might still be cases where this bug appears, but at least this makes it appear less often.
WofWca
force-pushed
the
wofwca/fix-jumpToMessage-different-chat
branch
from
7209c8f to
79e93ac
Compare
|
Test failure seems unrelated. |
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
WofWca
added a commit
that referenced
this pull request
Jan 31, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
WofWca
added a commit
that referenced
this pull request
Jan 31, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when the chatId of the message is different
from the currently open chat.
Closes #4508.
This is probably related to the React upgrade,
which changed the behaviour of
useEffect.The issue was that we called
window.__internal_jump_to_messagebefore
MessageListStorehas been reinstantiated,so we'd call it on an old instance.
I think there might still be cases where this bug appears,
but at least this makes it appear less often.