fix: improve __jump_to_message reliability
#4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
4832061 to
4701d5d
Compare
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
2 times, most recently
from
e8f3b2e to
6dddd28
Compare
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
6dddd28 to
4d7b919
Compare
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
4d7b919 to
321ef27
Compare
This was referenced Jan 25, 2025
WofWca
added a commit
that referenced
this pull request
Jan 25, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
nicodh
reviewed
Jan 28, 2025
There was a problem hiding this comment.
When reviewing this and the whole "jumpToMessage" logic, it seems we should clarify and/or document what is going on (perhaps improve the comment in jumpToMessage in MessageListStore)
We have now:
a function _window._internal_jump_to_message
another function _window._internal_check_jump_to_message
an object maybeJumpToMessageHack which is assigned to window.__internal_jump_to_message_asap which has a property jumpToMessageArgs which holds a addMessageIdToStack
Maybe a list of use cases would help. Ideally some (for now manual) tests, to make sure changes do not break anything?
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
321ef27 to
b052640
Compare
|
OK, I force-pushed the initial commit to clarify those |
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
dd628c9 to
2b33c44
Compare
nicodh
approved these changes
Jan 29, 2025
WofWca
force-pushed
the
wofwca/fix-jump_to_message-reliability
branch
from
2b33c44 to
8754014
Compare
WofWca
added a commit
that referenced
this pull request
Jan 31, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
WofWca
added a commit
that referenced
this pull request
Jan 31, 2025
That is, when you jump to a message in a different chat (e.g. by clicking on a notification, or from message search, or from a "private reply" quote), we would momentarily show the new chat scrolled to bottom prior to jumping to the desired message. Why this is bad: - We mark the visible messages as read. In this case that would be the last messages in the chat. But they weren't actually read, the user did not intend to scroll to them. - Extra layout shifting: not great visually. - Bad for performance. Let's just load the part of the chat that we need right away. Related: - #4508 - #4510 - #4554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 6a656f9
(#4510).
Partially addresses #4508.
Why partially? Because the bug appears to still happen sometimes.
But this commit should make it more reliable, or at least be a refactor.
This should also improve performance in some cases,
thanks to the removal of
setTimeout().