improvement: a11y: add arrow-key nav to gallery #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2024
WofWca
force-pushed
the
wofwca/arrow-keys-gallery
branch
from
58c89f9 to
37706b7
Compare
WofWca
force-pushed
the
wofwca/arrow-keys-gallery
branch
from
37706b7 to
6509ca7
Compare
WofWca
changed the title
WofWca
force-pushed
the
wofwca/arrow-keys-gallery
branch
from
6509ca7 to
f934757
Compare
WofWca
added a commit
that referenced
this pull request
Dec 24, 2024
This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
added a commit
that referenced
this pull request
Dec 24, 2024
This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
added a commit
that referenced
this pull request
Dec 24, 2024
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
added a commit
that referenced
this pull request
Dec 24, 2024
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
force-pushed
the
wofwca/arrow-keys-gallery
branch
from
f934757 to
8fff759
Compare
WofWca
added a commit
that referenced
this pull request
Jan 12, 2025
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
WofWca
added a commit
that referenced
this pull request
Jan 12, 2025
See bvaughn/react-window#420 (comment). This commit simply moves the renderer function definition from inline to top-level. This does not appear to have functional impact as of now, but will come in handy after #4376.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: