fix: chat "scrolling up" because of imgs loading #4431
Conversation
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-quote-imgs
branch
from
3f8b90b to
410127a
Compare
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-quote-imgs
branch
from
410127a to
0b05ac9
Compare
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-quote-imgs
branch
from
0b05ac9 to
ada6bf5
Compare
|
An alternative solution would be #4314. |
| height: var(--quote-img-size); | ||
| // do not set width, to keep the aspect ratio (see https://github.com/deltachat/deltachat-desktop/issues/3931) | ||
| width: var(--quote-img-size); |
There was a problem hiding this comment.
Is object-fit: scale-down in conjunction with width: 100% not enough (and better since it does not force any image to have a 36px width)?
I tested various variants with extreme landscape ratios and text and it looked better.
But I can also live with the current solutions, since we are going to find amore adaptive generic solution for images anyway (hopefully)
There was a problem hiding this comment.
Have you tried quoting a in image with a captoion or just an image?
There was a problem hiding this comment.
I tried with text and without. But it's true, with an extrem ratio (like 1300 x 30 px) it hides the text. So let's solve that hopefully soon as said above
There was a problem hiding this comment.
width: 100% simply makes it take up 50% of the flex container, which can be adjusted with flex-shrink. IDK if this is what we want.
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-quote-imgs
branch
from
ada6bf5 to
a4e2290
Compare
Visual aspect, before / after:
This, together with #4407,
should close #4404.
The bug was introduced in #3999.
Pior to that we used to have fixed width on quoted images as well.
This commmit practically reverts that MR, but also adds
object-fitandobject-position, and is now in line withmessage attachment images