fix: update gallery on message deleted #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/update-gallery-on-messages-deleted
branch
from
1893e1f to
18fdbaa
Compare
nicodh
approved these changes
Jan 6, 2025
| }) | ||
| } | ||
| ) | ||
| this.cleanup.push(toCleanup) |
There was a problem hiding this comment.
Why is this an array? Can componentDidMount be called multiple times, without componentWillUnmount being called before?
There was a problem hiding this comment.
I don't think so. It's an array because we might want to add something else there later, we have similar cleanup arrays in the codebase.
WofWca
force-pushed
the
wofwca/update-gallery-on-messages-deleted
branch
from
18fdbaa to
f350198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4318.