feat: display past chat members #4531
Draft
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
requested changes
Jan 22, 2025
Comment on lines
142
to
143
| BackendRemote.rpc | ||
| .getContactsByIds(accountId, group.pastContactIds) | ||
| .then(pastContacts => { | ||
| setPastContacts(Object.values(pastContacts)) | ||
| }) |
There was a problem hiding this comment.
This needs to be in useEffect in order to not call this on every re-render.
Perhaps also with outdated variable, as in https://github.com/deltachat/deltachat-desktop/pull/4500/files.
| {pastContacts.length > 0 && ( | ||
| <> | ||
| <div className='group-separator'> | ||
| {pastContacts.length} Past Members |
There was a problem hiding this comment.
Adding translation at deltachat/deltachat-android#3587
link2xt
force-pushed
the
link2xt/past-members
branch
from
29da587 to
b44eed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use together with deltachat/deltachat-core-rust#6442