improvement: better shortcuts #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WofWca
commented
Jan 30, 2025
WofWca
commented
- improvement: Ctrl + F to focus search
- improvement: Enter or ArrowDown to focus 1st item
- improvement: don't clear search on focus
- improvement: Ctrl+M to focus composer, not Ctrl+N
- feat: Ctrl + N to open "Create Chat"
- feat: add Ctrl + Shift + F to search in chat
Instead of opening the first chat. This is now preferable, since we have arrow key navigation in the chat list.
Clearing the input is very easy anyway. We should not clear it automatically in case e.g. the user wants to come back to it and adjust the search, or if they're simply using it as a convenient way to get the focus closer to when they need it to be.
Ctrl + N is associated with "New", which would rather be the "plus" button in the chat list. Let's associate "M" with "message". See [Reconsider Ctrl + N shortcut to open "New Chat" dialog instead of focusing message input](#4243).
WofWca
force-pushed
the
wofwca/shortcuts
branch
from
317167a to
e30095f
Compare
WofWca
force-pushed
the
wofwca/shortcuts
branch
from
e30095f to
67fbd39
Compare
WofWca
force-pushed
the
wofwca/shortcuts
branch
from
67fbd39 to
21791fc
Compare
nicodh
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Good improvement!
Btw. when looking at the Shortcut Hints: on my Linux & MacBook the Shortcut to show the Hints is Strg + - not /
(dash not slash)
UI: would be nice to have margins around the <keyboard elements and to make the dialog wider to allow 3 buttons in one row
Both can go into a separate PR of course
Hmmm. This is weird. I don't see how this could be the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.