Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Show in Chat" in gallery not working #4629

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Feb 11, 2025

The bug was likely introduced in
#4554
(da4b916).
FYI the bug has only been released with 1.53.0.

@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from 34109bc to a8faa52 Compare February 11, 2025 20:05
@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from a8faa52 to b336bc9 Compare February 11, 2025 20:05
@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from a8d5748 to 5730919 Compare February 11, 2025 20:53
@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from 5730919 to 1f536ff Compare February 11, 2025 20:55
@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from 1f536ff to f4806bc Compare February 11, 2025 20:56
Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by reading & testing

The bug was likely introduced in
#4554
(da4b916)
or in one of the adjacent / related commmits.
FYI the bug has only been released with 1.53.0.
i.e. ensure that `__internal_check_jump_to_message`
was set by this component instance prior to resetting it.

This doesn't appear to fix any current bugs,
but hopefully will save us later.
@WofWca WofWca force-pushed the wofwca/fix-jumpToMessage-from-gallery branch from f4806bc to d8ffa75 Compare February 13, 2025 10:42
@WofWca WofWca merged commit 56bccd0 into main Feb 13, 2025
2 of 8 checks passed
@WofWca WofWca deleted the wofwca/fix-jumpToMessage-from-gallery branch February 13, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants