-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern buttons & button icons #2584
Conversation
…s is somehow more far away from 'New chat' title
e1857b4
to
138e4e0
Compare
2681be5
to
5d54205
Compare
I feel like the profile switcher would be nicer if the mute icon was on the right and instead of the checkmark we'd show which was selected using the background color. |
the checkmark is a standard symbol, and its place is the default place. so, i would not change that. only a background colour would make things less clear, also wrt accessibility. don't make me think :) for the mute icon: i am not too happy with its position and that a "column" is reserved for it, even if unused. in the other parts of the app, we do not do that. so maybe having the icon inlined, left or right of the title might be better. but it is also good enough as it is now :) anyways, this is a bit out of scope of this PR |
We put the mute icon in front in Android but the space is not reserved even if the mute icon is not shown, we also do it like that in the chat list, But in Telegram it is shown at the end of the title instead of the beginning, I think at the end actually makes the UI better because then all titles are perfectly aligned at the start and just put the mute icon appended at the end of the title/name, but at this point with so many incoherences in that account selector (some items with subtitle others centered without subtitle so items have different sizes, etc) I would say this is just a small drop in the bucket and not a big problem as it is |
this PR modernises the buttons used in profiles, settings etc. this is another step much easier possible after dropping ios12
menus meanwhile also have icons: for better recognition, it makes sense that same functions show up similar (affects eg. "share" or "add to widget" but also "delete")
esp. the "QR code" icon at "New Contact" is a win; this was figured out on android to make quite some difference in ux
left-align buttons as meanwhile usual in virtually all comparable apps and screens
for the other icons, we stay conservative and do not add too many things, eg. "add" is a simply plus sign at most places - for adding profiles, groups, members, proxies
some impressions of affected screens: