flatten menus #2586
Merged
flatten menus #2586
+53
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/bring-back-delete
branch
2 times, most recently
from
0e04786 to
cbcdffe
Compare
before, delete as last item was separated,
which stands a bit in the way of adding it to already separated last "more..." item
(we could separate both, but that is ugly)
looking at lots of other apps, however,
"delete" is not separated in most of them ("gallery" is a prominent exception)
r10s
force-pushed
the
r10s/bring-back-delete
branch
from
cbcdffe to
c4143ea
Compare
having 'delete' at 'more' was kind of an experiment, however, with new 'saved messages', things have changed: one wants to quickly 'unsave' messaes, however, from inside 'saved messages', delete is more logical, as it is a copy and as there are also other messages inside 'saved messages' (eg. notes)
r10s
force-pushed
the
r10s/bring-back-delete
branch
from
0ff678d to
2f3d986
Compare
…time we did not had a 'more' menu
adbenitez
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the message menu suffered from constant space problems - the reaction menu and the "select more" left only place for at most 5 items - which was often enough exceeded, resulting in a scrolling menu.
also, the "delete" item was not present in the first row, which was kind of and experiment, which, however also iMessage is doing. with "unsave" in save message getting replaced by "deleted" in the future, however "delete" becomes more important, so this PR adds that back unconditionally.
same for "share" which is now also easier accessible. "Copy image" and "Reply privately", otoh, requires to open "more", however, compared to reply/forward/save/copy-text/delete, this is also a less often used and acceptable.
info/share/resend was moreover only accessible with 3 taps, now you need 2 only, and can even do it by 1 with hold-to-select
to make room for less often used icons, we added a "more" menu, that then shows "select" as an option - beside other things. multiple select is now also available with a two-finger swipe, so that seems totally fine.
so, finally, we also have a place for the maybe upcoming "pin message" and for other stuff.
this is how the new menu looks like:
@adbenitez the replacement of the "star" by "bookmark" will be done in a subsequent PR
EDIT: ah, and this PR also goes for the standard "forward" icon - we could change that on android as well
before ...
before, the menu was often scrolling, note the scrollbar in the following screenshot, the missing "delete" and the "more" would appear on scrolling only ...
... and "info" and "share" quite far away in the "select more overflow menu" ...
... ftr, the old state was as it is also because of other constraints we had when we needed to support iOS 12, which had a completely different menu approach. meanwhile things got simpler and we can clean up :)