hack around broken 'Add Second Device' QR code #2595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core 1.155.2 accidentally broke compatibility to add-second-device QR codes of previous versions; this is esp. bad as ppl will have different versions for some days at least, weakening overall UX, esp. of first-time-users that may come to delta because of praised, seamless multidevice ... :) this PR is a little experiment, if it is really only the minor JSON change, or sth deeer. seems, these two repacements fix the issue, allowing us to release much mess stressful, while users being happy. if we think, this is fine, we should do that better in core, however. the hack can be removed 3 releases later or so.
r10s
changed the title
|
replaced by deltachat/deltachat-core-rust#6528 |
r10s
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Feb 10, 2025
this converts old QR codes to the new format, in an hacky, but simple way, see #6518 for more details and for code snippet then QR code change is esp. bad as ppl will have different versions for some days at least, weakening overall UX, esp. of first-time-users that may come to delta because of praised, seamless multidevice ... :) i tested in deltachat/deltachat-ios#2595 that this actually fixes the problem, and there is no deeper issue with changed chashes or so - seemed not to be the case, at least, with this hack, core accepts QR codes from the released 1.52-and-before series this hack gives user time to update, it can be removed after some months (we can also remove the old BACKUP qr code alltogether then) we should still not wait too long with the PR as there are already versions out with the "new/bad" QR code (and growing, as new iOS installations will get the new format, one cannot revert a version, only pause rollout) --------- Co-authored-by: link2xt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core 1.155.2 accidentally broke compatibility
to add-second-device QR codes of previous versions;
this is esp. bad as ppl will have different versions for some days at least, weakening overall UX, esp. of first-time-users
that may come to delta because of praised, seamless multidevice ... :)
this PR is a little experiment, if it is really only the minor JSON change, or sth deeer.
seems, these two repacements fix the issue,
allowing us to release much mess stressful,
while users being happy.
if we think, this is fine,
we should do that better in core, however.
the hack can be removed 3 releases later or so.
see deltachat/deltachat-core-rust#6518 for more details and for snippets how the QR code looks and what this hack is doing
cc @link2xt