Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandiant v 1 1 #36047

Conversation

adamlevymandiant
Copy link
Contributor

@adamlevymandiant adamlevymandiant commented Aug 27, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

NA

Description

New version that:

  • Splits Feed and Enrichment commands into separate integrations
  • Enhances the readable output for the cve, mati-get-actor, mati-get-malware, mati-get-campaign commands

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Aug 27, 2024
@content-bot content-bot changed the base branch from master to contrib/adamlevymandiant_mandiant_v_1_1 August 27, 2024 17:54
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @barryyosi-panw will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @adamlevymandiant, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@kgal-pan
Copy link
Contributor

@adamlevymandiant - Can you please sync the fork? It should resolve the Setup Environment check failing and the pre-commit validation failure.

Also, can you please increase the code coverage for Feed Mandiant integration? Seems that we're lower than the 70% threshold.

@adamlevymandiant
Copy link
Contributor Author

@kgal-pan - thank you for the guidance, I have synced my fork and pushed a commit increasing test coverage above 70%

@kgal-pan kgal-pan removed the request for review from thefrieddan1 August 28, 2024 14:53
adamlevymandiant and others added 21 commits September 12, 2024 11:38
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence.yml

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence_description.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence_description.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence_description.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/FeedMandiantThreatIntelligence_description.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>
…diantThreatIntelligence/README.md

Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
@thefrieddan1 thefrieddan1 added post-demo and removed pending-demo Demo pending labels Sep 22, 2024
@thefrieddan1 thefrieddan1 merged commit 76df614 into demisto:contrib/adamlevymandiant_mandiant_v_1_1 Sep 22, 2024
20 checks passed
@content-bot content-bot mentioned this pull request Sep 22, 2024
5 tasks
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

thefrieddan1 added a commit that referenced this pull request Sep 22, 2024
* Increment Pack version

* Adding FeedMandiant integration with dummy data

* Add enrichment integration

* v1.1.0 reclease candidate 1

* Increase test coverage in FeedMandiant

* add description to get-indicators cmd in yml

* Formatting updates to yml files

* Fix validation errors in docs

* Fix validation errors

* Fix validation errors

* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Apply suggestions from code review



* Apply suggestions from code review



* Apply suggestions from doc review



* Fix Mitre Attack mapping and add ioc limit for feed runs

---------

Co-authored-by: adamlevymandiant <[email protected]>
Co-authored-by: barryyosi-panw <[email protected]>
Co-authored-by: Kobbi Gal <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Increment Pack version

* Adding FeedMandiant integration with dummy data

* Add enrichment integration

* v1.1.0 reclease candidate 1

* Increase test coverage in FeedMandiant

* add description to get-indicators cmd in yml

* Formatting updates to yml files

* Fix validation errors in docs

* Fix validation errors

* Fix validation errors

* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Apply suggestions from code review



* Apply suggestions from code review



* Apply suggestions from doc review



* Fix Mitre Attack mapping and add ioc limit for feed runs

---------

Co-authored-by: adamlevymandiant <[email protected]>
Co-authored-by: barryyosi-panw <[email protected]>
Co-authored-by: Kobbi Gal <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Increment Pack version

* Adding FeedMandiant integration with dummy data

* Add enrichment integration

* v1.1.0 reclease candidate 1

* Increase test coverage in FeedMandiant

* add description to get-indicators cmd in yml

* Formatting updates to yml files

* Fix validation errors in docs

* Fix validation errors

* Fix validation errors

* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/ReleaseNotes/1_1_0.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/Mandiant/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence.yml



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/FeedMandiantThreatIntelligence_description.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Update Packs/MandiantAdvantageThreatIntelligence/Integrations/FeedMandiantThreatIntelligence/README.md



* Apply suggestions from code review



* Apply suggestions from code review



* Apply suggestions from doc review



* Fix Mitre Attack mapping and add ioc limit for feed runs

---------

Co-authored-by: adamlevymandiant <[email protected]>
Co-authored-by: barryyosi-panw <[email protected]>
Co-authored-by: Kobbi Gal <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved post-demo TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants