Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pack][RecordedFuture][v1.7.14] #36304

Open
wants to merge 5 commits into
base: contrib/recordedfuture-dev_recordedfuture_pack_v1_7_14
Choose a base branch
from

Conversation

recordedfuture-dev
Copy link
Contributor

RecordedFuture Pack v1.7.14

Contributing to Cortex XSOAR Content

Status

  • Ready

Description

Integrations

Recorded Future v2
  • Added collective_insights argument to the following commands:
    • ip
    • domain
    • url
    • file
    • cve
Recorded Future - Playbook Alerts
  • Added the following arguments to the recordedfuture-playbook-alerts-update command:
    • reopen
    • comment

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Sep 12, 2024
@content-bot content-bot changed the base branch from master to contrib/recordedfuture-dev_recordedfuture_pack_v1_7_14 September 12, 2024 18:23
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @rshunim will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @recordedfuture-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@rshunim
Copy link
Contributor

rshunim commented Sep 15, 2024

Hi @recordedfuture-dev, thanks for your contribution.
Starting the code review

Copy link
Contributor

@rshunim rshunim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @recordedfuture-dev, very impressive code, good job!

  1. Please see my comments
  2. After fixing them, we can set a demo session or you can send me a short video demo
    (you can do it via Slack, my name is Roei Shunim)

Thanks a lot again!

@rshunim
Copy link
Contributor

rshunim commented Sep 16, 2024

@ShirleyDenkberg Please review the pr

@ShirleyDenkberg
Copy link
Contributor

@rshunim Doc review completed.
@recordedfuture-dev I recommend making the changes to the yml file that I made in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants