Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change problematic verbiage of black/white – replace with block/allow #36376

Open
wants to merge 6 commits into
base: contrib/ali-sawyer_tim-process-verbiage-change
Choose a base branch
from

Conversation

ali-sawyer
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

n/a

Description

Replaces the offensive wording of "blacklist" and "whitelist" with the accepted industry standard terms of "blocklist" and "allowlist". As we are pushing this pack to more customers, it is important to update this verbiage to align with our values.

References:

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 18, 2024
@content-bot content-bot changed the base branch from master to contrib/ali-sawyer_tim-process-verbiage-change September 18, 2024 03:58
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @rshunim will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @ali-sawyer, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Sep 18, 2024
@rshunim
Copy link
Contributor

rshunim commented Sep 18, 2024

Hi @ali-sawyer, Thanks for your fixes.
The PR is approved by me.
@tomer-pan I'd appreciate your review too.
Regarding the RN file . Please fix the file so the validation passes

@rshunim
Copy link
Contributor

rshunim commented Sep 18, 2024

Hi @ShirleyDenkberg, there are small changes here in the documentation, please review it too

@ShirleyDenkberg
Copy link
Contributor

@rshunim @tomer-pan Doc review completed.

@@ -1,15 +1,15 @@
{
"id": "Review Indicators Manually For Whitelisting",
"id": "Review Indicators Manually For Allowlisting",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ali-sawyer
Changing incident type id and name will affect all other places using this object.
For example, in the playbook "TIM - Process AWS indicators" (FeedAWS pack) - there's a task named "Create Process Indicators Manually incident" which creates a new incident from that type. There are others as well.
If we change the id+name of this incident type, we should iterate through all of the other places which uses this incident type and change them as well to use the new name/id so they won't break.

@tomer-pan
Copy link
Contributor

@ali-sawyer @rshunim
For all the places where the description is changed - that's not an issue.
BUT when changing IDs of objects, it will affect other objects using it.
For example other playbooks that count on the old name or even customers' custom playbooks or other objects which use the current layout or incident type IDs - we can potentially break those.
So, we should make sure to address all of the other OOTB content which uses the old IDs and maybe even show a breaking change note for this release which states that all custom content that relies on the layout or incident type might break and appropriate changes should be done to this custom content.

@ali-sawyer
Copy link
Contributor Author

@tomer-pan that makes sense. I updated the references in the other feed packs that use the content that was renamed. Lmk if I should add a breaking change note.

@tomer-pan
Copy link
Contributor

@ali-sawyer Thanks, now all looks good.
And yes, please add a breaking change note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants