-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change problematic verbiage of black/white – replace with block/allow #36376
base: contrib/ali-sawyer_tim-process-verbiage-change
Are you sure you want to change the base?
Change problematic verbiage of black/white – replace with block/allow #36376
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @rshunim will know the proposed changes are ready to be reviewed. |
Hi @ali-sawyer, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
Hi @ali-sawyer, Thanks for your fixes. |
Hi @ShirleyDenkberg, there are small changes here in the documentation, please review it too |
@rshunim @tomer-pan Doc review completed. |
@@ -1,15 +1,15 @@ | |||
{ | |||
"id": "Review Indicators Manually For Whitelisting", | |||
"id": "Review Indicators Manually For Allowlisting", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ali-sawyer
Changing incident type id and name will affect all other places using this object.
For example, in the playbook "TIM - Process AWS indicators" (FeedAWS pack) - there's a task named "Create Process Indicators Manually incident" which creates a new incident from that type. There are others as well.
If we change the id+name of this incident type, we should iterate through all of the other places which uses this incident type and change them as well to use the new name/id so they won't break.
@ali-sawyer @rshunim |
@tomer-pan that makes sense. I updated the references in the other feed packs that use the content that was renamed. Lmk if I should add a breaking change note. |
@ali-sawyer Thanks, now all looks good. |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
n/a
Description
Replaces the offensive wording of "blacklist" and "whitelist" with the accepted industry standard terms of "blocklist" and "allowlist". As we are pushing this pack to more customers, it is important to update this verbiage to align with our values.
References:
Must have