Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/js): align error messages #25406

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Sep 3, 2024

Aligns the error messages in the cli/js folder to be in-line with the Deno style guide.

#25269

@irbull
Copy link
Contributor Author

irbull commented Sep 3, 2024

I'm not sure about this one. This required some changes to integration tests as many of those test results included a period in their output (which is not standard for Deno or V8). I've updated the test output in this PR so things should pass (it all passes locally).

Aligns the error messages in the cli/js folder to be in-line with the
Deno style guide.

denoland#25269
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 939c23f into denoland:main Sep 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants