Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reenable more tests after DENO_FUTURE migration #25752

Merged
merged 3 commits into from
Sep 24, 2024
Merged

refactor: reenable more tests after DENO_FUTURE migration #25752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
095418a
both_package_json_selected
bartlomieju Sep 20, 2024
1eacbd7
decrease test count
bartlomieju Sep 20, 2024
c2475a8
Merge branch 'main' into rewrite_more_tests
bartlomieju Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tests/integration/task_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,6 @@
// http_server: true,
// });

// TODO(2.0): not entirely clear what's wrong with this test
// itest!(task_both_package_json_selected {
// args: "task bin asdf",
// cwd: Some("task/both/"),
// output: "task/both/package_json_selected.out",
// copy_temp_dir: Some("task/both/"),
// envs: env_vars_for_npm_tests(),
// exit_code: 0,
// http_server: true,
// });

// TODO(2.0): not entirely clear what's wrong with this test but it hangs for more than 60s
// itest!(task_npx_on_own {
// args: "task on-own",
Expand Down
10 changes: 10 additions & 0 deletions tests/specs/task/both_package_json_selected/__test__.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"tempDir": true,
"steps": [
{
"args": "install",
"output": "install.out"
},
{ "args": "task bin asdf", "output": "package_json_selected.out" }
]
}
0 tests/testdata/task/both/deno.json → ...task/both_package_json_selected/deno.json
View file
Open in desktop
File renamed without changes.
5 changes: 0 additions & 5 deletions ...tdata/task/both/package_json_selected.out → ...sk/both_package_json_selected/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
Download http://localhost:4260/@denotest/bin
Download http://localhost:4260/@denotest/bin/1.0.0.tgz
Initialize @denotest/[email protected]
Task bin cli-esm testing this out "asdf"
testing
this
out
asdf
0 tests/testdata/task/both/package.json → ...k/both_package_json_selected/package.json
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions tests/specs/task/both_package_json_selected/package_json_selected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Task bin cli-esm testing this out "asdf"
testing
this
out
asdf
2 changes: 1 addition & 1 deletion tools/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ async function ensureNoNewITests() {
"repl_tests.rs": 0,
"run_tests.rs": 331,
"shared_library_tests.rs": 0,
"task_tests.rs": 4,
"task_tests.rs": 3,
"test_tests.rs": 0,
"upgrade_tests.rs": 0,
"vendor_tests.rs": 1,
Expand Down