Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): Use SafeRexExp for ext/node/polyfills/path/separator.ts #27603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ext/node): Use SafeRexExp for ext/node/polyfills/path/separator.ts #27603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3ca12
Use `SafeRexExp` for separator module
finleyjb Jan 6, 2025
ac881e3
Trigger build
finleyjb Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ext/node/polyfills/path/separator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
// Copyright 2018-2025 the Deno authors. MIT license.

// TODO(petamoriken): enable prefer-primordials for node polyfills
// deno-lint-ignore-file prefer-primordials

import { primordials } from "ext:core/mod.js";
import { isWindows } from "ext:deno_node/_util/os.ts";

const { SafeRegExp } = primordials;

export const SEP = isWindows ? "\\" : "/";
export const SEP_PATTERN = isWindows ? /[\\/]+/ : /\/+/;
export const SEP_PATTERN = isWindows
? new SafeRegExp("[\\/]+")
: new SafeRegExp("\/+");
finleyjb marked this conversation as resolved.
Show resolved Hide resolved
Loading