fix(ext/net): resolveDns tts option #27676
Open
+171
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releated issiue #27669
Added tts option to Deno.resolveDns, with that created a new return type: RecordWithTts (similiar with node)
Now node/dns resolve4 and resolve6 work well with tts option
I'm not so sure about some points, like objects that have RecordWithTts type have null prototype, i dont know how to handle this in op function.
And the test case fails because of compressing ipv6 (:0: differences)
I can change the pr to draft after a review
✔ tools/format
✔ tools/lint
✖ cargo/test
✖ jsdoc