Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add fs.lstat #6276

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

IgorM867
Copy link
Contributor

This PR adds lstat API to @std/fs.

towards #6255

@IgorM867 IgorM867 requested a review from kt3k as a code owner December 17, 2024 15:11
@github-actions github-actions bot added the fs label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (8573618) to head (01dc944).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_lstat.ts 52.63% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6276      +/-   ##
==========================================
- Coverage   96.34%   96.32%   -0.02%     
==========================================
  Files         543      544       +1     
  Lines       41601    41620      +19     
  Branches     6312     6313       +1     
==========================================
+ Hits        40079    40091      +12     
- Misses       1478     1486       +8     
+ Partials       44       43       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kt3k kt3k merged commit 450bdfb into denoland:main Dec 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants