-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fs/unstable): add chmod and chmodSync #6343
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6343 +/- ##
==========================================
- Coverage 96.40% 96.37% -0.04%
==========================================
Files 549 550 +1
Lines 41851 41880 +29
Branches 6348 6351 +3
==========================================
+ Hits 40348 40362 +14
- Misses 1463 1478 +15
Partials 40 40 ☔ View full report in Codecov by Sentry. |
We can't use Deno specific features (such as One way to work around it is to use |
Ahh, I see. I'll start updating the tests. I appreciate the guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the test. Now this looks perfect!
This PR adds the
chmod
andchmodSync
APIs to@std/fs
, which are functions intended to mirrorDeno.chmod
andDeno.chmodSync
, respectively.Towards #6255.