Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add I64LEB128 #12

Merged
merged 23 commits into from
Apr 26, 2023
Merged

feat: add I64LEB128 #12

merged 23 commits into from
Apr 26, 2023

Conversation

MierenManz
Copy link
Collaborator

@MierenManz MierenManz commented Apr 20, 2023 •
edited by eliassjogreen
Loading

Still write tests left todo.

Closes #5

@eliassjogreen eliassjogreen changed the title Feat: Add I64LEB128 feat: add I64LEB128 Apr 21, 2023
@MierenManz
Copy link
Collaborator Author

Should be ready for review

eliassjogreen
eliassjogreen approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixed up some small issues (mostly to do with structure and naming) I didn't feel like bothering you with. Merging this now :D

Thanks Skye!

@eliassjogreen eliassjogreen merged commit 80802e1 into denosaurs:main Apr 26, 2023
@MierenManz MierenManz deleted the i64LEB128 branch April 26, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliassjogreen eliassjogreen eliassjogreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LEB128
2 participants
@MierenManz @eliassjogreen