Added get multiple api for badger #1990
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -273,6 +273,113 @@ func (s *levelHandler) getTableForKey(key []byte) ([]*table.Table, func() error) | |
| return []*table.Table{tbl}, tbl.DecrRef | ||
| } | ||
|
|
||
| func (s *levelHandler) getBatch(keys [][]byte, done []bool) ([]y.ValueStruct, error) { | ||
| // Find the table for which the key is in, and then seek it | ||
| getForKey := func(key []byte) (y.ValueStruct, func() error, []*table.Iterator) { | ||
| tables, decr := s.getTableForKey(key) | ||
| keyNoTs := y.ParseKey(key) | ||
|
There was a problem hiding this comment. we should just parse the key once, we are doing it again and again |
||
| itrs := make([]*table.Iterator, 0) | ||
|
|
||
| hash := y.Hash(keyNoTs) | ||
| var maxVs y.ValueStruct | ||
| for _, th := range tables { | ||
| if th.DoesNotHave(hash) { | ||
| y.NumLSMBloomHitsAdd(s.db.opt.MetricsEnabled, s.strLevel, 1) | ||
| continue | ||
| } | ||
|
|
||
| it := th.NewIterator(0) | ||
| itrs = append(itrs, it) | ||
|
|
||
| y.NumLSMGetsAdd(s.db.opt.MetricsEnabled, s.strLevel, 1) | ||
| it.Seek(key) | ||
| if !it.Valid() { | ||
| continue | ||
| } | ||
| if y.SameKey(key, it.Key()) { | ||
| if version := y.ParseTs(it.Key()); maxVs.Version < version { | ||
| maxVs = it.ValueCopy() | ||
| maxVs.Version = version | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return maxVs, decr, itrs | ||
| } | ||
|
|
||
| // Use old results from getForKey and find in those tables. | ||
| findInIter := func(key []byte, itrs []*table.Iterator) y.ValueStruct { | ||
| var maxVs y.ValueStruct | ||
|
|
||
| for _, it := range itrs { | ||
| it.Seek(key) | ||
| if !it.Valid() { | ||
| continue | ||
|
|
||
| } | ||
| if y.SameKey(key, it.Key()) { | ||
| if version := y.ParseTs(it.Key()); maxVs.Version < version { | ||
| maxVs = it.ValueCopy() | ||
| maxVs.Version = version | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return maxVs | ||
| } | ||
|
|
||
| results := make([]y.ValueStruct, len(keys)) | ||
| // For L0, we need to search all tables each time, so we can just call get() as required | ||
| if s.level == 0 { | ||
| var err error | ||
| for i, key := range keys { | ||
| if done[i] { | ||
| continue | ||
| } | ||
| results[i], err = s.get(key) | ||
| if err != nil { | ||
| return results, err | ||
| } | ||
| } | ||
| return results, nil | ||
| } else { | ||
|
There was a problem hiding this comment. @harshil-goel I need to understand this code block (lines 344-373) ... will sync up with you offline. |
||
| decr := func() error { return nil } | ||
| var itrs []*table.Iterator | ||
|
|
||
| started := false | ||
| for i := 0; i < len(keys); i++ { | ||
| if done[i] { | ||
| continue | ||
| } | ||
| if !started { | ||
| var maxVs y.ValueStruct | ||
| maxVs, decr, itrs = getForKey(keys[0]) | ||
| results[i] = maxVs | ||
| started = true | ||
| } else { | ||
| results[i] = findInIter(keys[i], itrs) | ||
| // If we can't find in the current tables, maybe the | ||
| // data is there in other tables | ||
| if len(results[i].Value) == 0 { | ||
| for i := 0; i < len(itrs); i++ { | ||
| itrs[i].Close() | ||
| } | ||
| err := decr() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| results[i], decr, itrs = getForKey(keys[i]) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| for i := 0; i < len(itrs); i++ { | ||
| itrs[i].Close() | ||
| } | ||
| return results, decr() | ||
| } | ||
|
|
||
| } | ||
|
|
||
| // get returns value for a given key or the key after that. If not found, return nil. | ||
| func (s *levelHandler) get(key []byte) (y.ValueStruct, error) { | ||
| tables, decr := s.getTableForKey(key) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we rename
donetokeyReador something similar?