Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch potential deadlock #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

celrenheit
Copy link

@celrenheit celrenheit commented Feb 21, 2023

catch potential deadlock when the context is done but waiting to send on a channel in the default case

@celrenheit celrenheit changed the title catch potential deadlock when the context is done but waiting to send… catch potential deadlock Feb 21, 2023
@dgryski
Copy link
Owner

dgryski commented Mar 2, 2023

Do you have an example where this actually happened?

@celrenheit
Copy link
Author

I came across twice on an existing code doing:

select {
case <-ctx.Done():
// ...
default:
  ch <- 1
}

instead of

select {
case <-ctx.Done():
// ...
case ch <- 1:
}

This caused a deadlock blocking the exit.

I wasn't sure to open a PR for this, after using it to look for other issues like that, because it might raise false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants