Refactor rn movable view #1639
Open
Refactor rn movable view #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 19, 2024 19:13
…into refactor-rn-movable-view
… into feat-rn-comps-perf-events
hiyuki
reviewed
Nov 5, 2024
| const eventHandlers: Record<string, any> = {} | ||
| const catchEventList = [ | ||
| { name: 'onTouchStart', value: ['catchtouchstart'] }, | ||
| { name: 'onTouchMove', value: ['catchtouchmove', 'catchvtouchmove', 'catchvhouchmove'] }, |
hiyuki
reviewed
Nov 5, 2024
|
|
||
| const getValue = () => { | ||
| const getValue = useCallback(() => { |
hiyuki
reviewed
Nov 5, 2024
| groupValue, | ||
| notifyChange | ||
| } | ||
| }, [notifyChange]) |
There was a problem hiding this comment.
以及感觉包在一个大的useMemo里就可以，前面都不需要写useCallback
hiyuki
reviewed
Nov 5, 2024
| submit, | ||
| reset | ||
| } | ||
| }, [submit, reset]) |
hiyuki
reviewed
Nov 5, 2024
| @@ -69,10 +71,11 @@ const Label = forwardRef<HandlerRef<View, LabelProps>, LabelProps>( | |||
| triggerChange: noop | |||
hiyuki
reviewed
Nov 5, 2024
| const contextValue = useMemo(() => ({ | ||
| height: style.height || 10, | ||
| width: style.width || 10 | ||
| }), [style.width, style.height]) |
hiyuki
reviewed
Nov 5, 2024
| import useNodesRef, { HandlerRef } from './useNodesRef' | ||
| import { MovableAreaContext } from './context' | ||
| import { useTransformStyle, splitProps, splitStyle, DEFAULT_UNLAY_STYLE, wrapChildren, GestureHandler, flatGesture } from './utils' |
There was a problem hiding this comment.
这个DEFAULT_UNLAY_STYLE改名为HIDDEN_STYLE吧
hiyuki
reviewed
Nov 5, 2024
| const gesture = useMemo(() => { | ||
| return Gesture.Pan() | ||
| .onTouchesDown((e: GestureTouchEvent) => { | ||
| 'worklet' |
hiyuki
reviewed
Nov 5, 2024
| } | ||
| }) | ||
| .withRef(movableGestureRef) | ||
| }, [disabled, direction, inertia, outOfBounds, handleTriggerMove, handleTriggerStart, handleTriggerEnd]) |
There was a problem hiding this comment.
这里面有些依赖是必定变化的，会导致memo失效，不用重新执行的逻辑可以考虑都放在一个大memo中
hiyuki
reviewed
Nov 5, 2024
| <Animated.View | ||
| ref={nodeRef} | ||
| onLayout={onLayout} | ||
| style={[styles.container, innerStyle, animatedStyles, layoutStyle]} |
hiyuki
reviewed
Nov 5, 2024
| useNodesRef(props, ref, nodeRef, { | ||
| defaultStyle: styles.container | ||
| defaultStyle: styles.container, |
There was a problem hiding this comment.
这个地方defaultStyle不用传递了，把normalStyle作为style传递进去就可以，内部的getComputedStyle也直接使用这里传递的normalStyle，而不需要读取props.style了
hiyuki
reviewed
Nov 5, 2024
| } | ||
| } | ||
| if (simultaneousHandlers && simultaneousHandlers.length) { | ||
| gesture.simultaneousWithExternalGesture(...simultaneousHandlers) |
hiyuki
reviewed
Nov 5, 2024
| if (gesture?.nodeRefs) { | ||
| return gesture.nodeRefs | ||
| .map((item: { getNodeInstance: () => any }) => item.getNodeInstance()?.instance?.gestureRef || {}) | ||
| .filter(Boolean) |
hiyuki
reviewed
Nov 5, 2024
| } | ||
|
|
||
| export function flatGesture (gestures?: Array<GestureHandler>) { | ||
| return gestures && gestures.flatMap((gesture: GestureHandler) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.