-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update @comapeo/schema to 1.2.0, adding alerts and server #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we (1) release a new @mapeo/schema
(2) fix the type errors.
Could also be good to add a test that runs a remoteDetectionAlert
through the whole system to make sure it works. Maybe just create one and make sure we can read it.
I'm getting a type error on the On the other hand, I can't |
…ddRemoteDetectionAlertDataType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's time for us to make a new migration!
I think we plan to add this to a version of @mapeo/core
that the MVP doesn't depend on--something like v1.1.0. Given that, I think we'll need a new migration here.
Now that we've released |
@EvanHahn I'm having a couple of type errors on Also, the awana-lockfile-bot is showing a package-lock change with |
…emoteDetectionAlertDataType
I think something related to ts's structural typing is tripping us here. Since 'observation' and 'remoteDetectionAlert' both have a |
…emoteDetectionAlertDataType
Our project CRUD tests had a number of `ts-ignore`s and `any`s. This replaces those with type-safe code. I think this is a useful change on its own but will also make [an upcoming change][0] easier. [0]: #805
Our project CRUD tests had a number of `ts-ignore`s and `any`s. This replaces those with type-safe code. I think this is a useful change on its own but will also make [an upcoming change][0] easier. [0]: #805
…emoteDetectionAlertDataType
So, after this PR was merged I updated the branch but I still get what is basically the same type error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs a new migration (rather than deleting the old one), but I think is ready to go otherwise.
…emoteDetectionAlertDataType
remoteDetectionAlert
dataType
this installs a local version of mapeo-schema with
remoteDetectionAlert
schema.should close #806